Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for not checking deleted flag in getCrmIdByLabel #17424

Open
wants to merge 2 commits into
base: developer
Choose a base branch
from

Conversation

WMCyn
Copy link

@WMCyn WMCyn commented Apr 15, 2024

missing check for crmentity deleted flag

causing import to match deleted records

Description

added check for deleted flag in crmentity table

Testing

Import a quote that has a product with name that matches a product that has both an older deleted record and a newer on with the same name.

Changes

  • [ X] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

missing check for crmentity deleted flag

causing import to match deleted records
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant