Added validation to currency update. #17256
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rskrzypczak
requested changes
Aug 25, 2023
| App.Fields.Date.register('#datepicker', false, {}); | ||
| let form = container.find('.js-currency-update'); | ||
| let bank = form.find('#bank'); | ||
| container.on('click', '.js-download', function (e) { |
| </td> | ||
| <td class="fieldValue"> | ||
| <div class="row"> | ||
| <div class="col-md-5"> | ||
| <select name="bank" id="bank" class="select2 form-control"> | ||
| <select name="bank" id="bank" class="select2 form-control" required="true" data-validation-engine="validate[required]"> |
| @@ -16,27 +16,26 @@ | |||
| <strong>{\App\Language::translate('LBL_WARNING', $QUALIFIED_MODULE)}</strong> {\App\Language::translate('MSG_NO_NET_CONN', $QUALIFIED_MODULE)} | |||
| </div> | |||
| {/if} | |||
| <form class="form-horizontal" method="post" action="index.php?module={$MODULENAME}&view=Index&parent=Settings"> | |||
| <form class="form-horizontal js-currency-update" method="post" action="index.php?module={$MODULENAME}&view=Index&parent=Settings" data-js="container"> | |||
There was a problem hiding this comment.
Suggested change
| <form class="form-horizontal js-currency-update" method="post" action="index.php?module={$MODULENAME}&view=Index&parent=Settings" data-js="container"> | |
| <form class="form-horizontal js-currency-update_form" method="post" action="index.php?module={$MODULENAME}&view=Index&parent=Settings" data-js="container"> |
rskrzypczak
added
🔧 AmendmentsRequired
areksolek
added
✔ finished
rskrzypczak
requested changes
Aug 25, 2023
| </td> | ||
| <td class="fieldValue"> | ||
| <div class="row"> | ||
| <div class="col-md-5"> | ||
| <select name="bank" id="bank" class="select2 form-control"> | ||
| <option value="0" {if !$ACTIVE_BANK}selected{/if}>{\App\Language::translate('LBL_SELECT_OPTION', $QUALIFIED_MODULE)}</option> | ||
| <select name="bank" id="bank" class="select2 form-control" data-validation-engine="validate[required]"> |
There was a problem hiding this comment.
Why did you set this field as mandatory if you want to be able to delete a bank
rskrzypczak
added
🔧 AmendmentsRequired
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added validation to currency update.