Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omitted a parameter from the configuration report during system installation #17255

Open
wants to merge 1 commit into
base: developer
Choose a base branch
from
Open

Omitted a parameter from the configuration report during system installation #17255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions app/Utils/ConfReport.php
View file
Open in desktop
Expand Up @@ -48,7 +48,8 @@ class ConfReport
* @var string[]
*/
public static $container = ['php', 'env', 'ext', 'request', 'db', 'writableFilesAndFolders'];

/** @var string[] Skip writable files in install. */
public static $skipWritableFilesInInstall = ['config/Modules'];
/**
* Stability variables map.
*
Expand Down Expand Up @@ -1599,7 +1600,7 @@ private static function validateIsWritable(string $name, array $row, string $sap
$path = ROOT_DIRECTORY . \DIRECTORY_SEPARATOR . $path;
}
$exists = file_exists($path);
if (empty($row['mustExist']) && !$exists) {
if ((empty($row['mustExist']) || ((isset(\App\Process::$requestMode) && 'Install' === \App\Process::$requestMode) && in_array($name, static::$skipWritableFilesInInstall))) && !$exists) {
$row['mode'] = 'skipParam';
} else {
$row['status'] = \App\Fields\File::isWriteable($path, true);
Expand Down