Changes: RecordCollectors - catching and translation messages #17228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfe-yetiforce
added
the
▶ in progress
fabianfe-yetiforce
added
✔ finished
rskrzypczak
requested changes
Aug 2, 2023
| @@ -190,4 +190,4 @@ private function parseData(): void | |||
| unset($this->data['filings']); | |||
| $this->data = \App\Utils::flattenKeys($this->data, 'ucfirst'); | |||
| } | |||
| } | |||
| } | |||
app/RecordCollectors/Gus.php
Outdated
| * @var array | ||
| */ | ||
| protected array $validationMessages = [ | ||
| // to fill messages |
| @@ -157,9 +157,12 @@ | |||
| <span class="fa-solid fa-print mr-2"></span> | |||
| {\App\Language::translate('LBL_PRINT')} | |||
| </button> | |||
| {elseif isset($SEARCH_DATA['error'])} | |||
| {elseif isset($SEARCH_DATA['error']) } | |||
There was a problem hiding this comment.
Suggested change
| {elseif isset($SEARCH_DATA['error']) } | |
| {elseif isset($SEARCH_DATA['error'])} |
| <div class="alert alert-danger m-4" role="alert"> | ||
| <span class="mdi mdi-alert-circle-outline mr-2"></span>{$SEARCH_DATA['error']} | ||
| <span class="mdi mdi-alert-circle-outline mr-2"></span> | ||
| {foreach from=$SEARCH_DATA['error'] key=KEY item=VALUE} |
rskrzypczak
added
🔧 AmendmentsRequired
fabianfe-yetiforce
added
▶ in progress
rskrzypczak
reviewed
Aug 7, 2023
| @@ -117,7 +117,7 @@ public function search(): array | |||
| { | |||
| $companyNumber = str_replace([' ', ',', '.', '-'], '', $this->request->getByType('companyNumber', 'Text')); | |||
|
|
|||
| if (!$this->isActive() && empty($companyNumber)) { | |||
| if (empty($companyNumber) && !$this->isActive()) { | |||
There was a problem hiding this comment.
shouldn't it be "||" instead of "&&"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The changes made affect the translation of feedback messages from RecordCollector APIs.