Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(extension): allow import class from extension with dash in folder #1136

Merged
merged 1 commit into from Mar 6, 2024

Conversation

sylvainlehmann
Copy link

Yeswiki is unable to autoload load class from extension with dash or other namespaces invalid characters in his folder. The createPerformable function does not convert some caracters which are valid in folder name but not in namespace.

The fix use a regexp to extract alphanumeric characters from folder name and create a pascal case string without separators

@sylvainlehmann sylvainlehmann changed the title fix(extension): allow import class from extension with dash in folder … fix(extension): allow import class from extension with dash in folder Mar 6, 2024
@mrflos
Copy link
Contributor

mrflos commented Mar 6, 2024

well done! Thanks for adding the tests!

@mrflos mrflos merged commit e932e73 into doryphore-dev Mar 6, 2024
2 checks passed
@mrflos mrflos deleted the fix/extension-import-namespace branch March 6, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants