Add Support for Nerd Fonts 3.0 #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, I did the same thing by myself some weeks ago and realised it would be better to have a single place where people can still contribute to logo-ls and keep it maintained. Since you recently contributed, would you please checkout the issue I opened and let me know what you think? Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nerd Fonts has released a new version (version 3.0) which drops the whole, deprecated
nf-mdi-prefixed Material Icon glyphs.Thus, the text produced by
logo-lscan't be displayed with most recent Nerd Fonts anymore.Changes made in this PR address this update and change all icons to use the new Nerd Fonts 3.0 Material Icons.
There are also some new icons from other icon sets (such as a
nf-seti-godot) but I focussed this PR to only address the migration from deprecatednf-mdiicons to newly introducednf-md-icons.The only notable change that might be undesired is that the new PDF icon looks very different.