Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor mod: Using empty (U+0020) instead of brailEmpty #35

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

canta2899
Copy link

I've been using logo-ls for a while and in some cases white-spaces between icons and file names were rendered as follows.

brailEmpty

I checked out the implementation and noticed that the U+2800 Braille pattern has been used since commit 1a227b5 as a space character, except for when the -i flag is risen. However, I found out that U+2800 does not act as a proper space in the Unicode standard, according to this unicode-explorer page.

I replaced U+2800 with U+0020, the standard space character. Then, the output was properly rendered on every terminal.

empty

I hope this PR might be helpful and thank you for making logo-ls!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant