Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add New Plugin: Limit Custom Keyword Length (Min & Max Characters) #160

Merged
merged 2 commits into from Mar 4, 2024
Merged

Add New Plugin: Limit Custom Keyword Length (Min & Max Characters) #160

merged 2 commits into from Mar 4, 2024

Conversation

suryatanjung
Copy link
Contributor

Limit Custom Keyword Length (Min & Max Characters) - This plugin limits the minimum and maximum number of characters for custom keyword.

@suryatanjung
Add New Plugin: Limit Custom Keyword Length (Min & Max Characters)
d48285b 
Limit Custom Keyword Length (Min & Max Characters) - This plugin limits the minimum and maximum number of characters for custom keyword.
suryatanjung
suryatanjung commented Jan 25, 2024
View reviewed changes
Copy link
Contributor Author

@suryatanjung suryatanjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add New Plugin: Limit Custom Keyword Length (Min & Max Characters)

README.md Show resolved Hide resolved
dgw
dgw approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Future versions might support configuring the limits in the admin panel? But there's no reason not to accept this new plugin link now.

@suryatanjung
Copy link
Contributor Author

thank you hope this useful for future versions

@dgw dgw mentioned this pull request Jan 26, 2024
Closed
3 tasks
@suryatanjung suryatanjung deleted the patch-1 branch January 26, 2024 10:51
@suryatanjung suryatanjung restored the patch-1 branch January 26, 2024 10:52
suryatanjung
suryatanjung commented Jan 26, 2024
View reviewed changes
Copy link
Contributor Author

@suryatanjung suryatanjung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i mistakenly closed this patch

@suryatanjung suryatanjung reopened this Jan 26, 2024
@suryatanjung suryatanjung requested a review from dgw January 26, 2024 11:02
This was referenced Jan 26, 2024
Closed
Closed
dgw
dgw approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@dgw dgw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had already approved this. Please just wait for another maintainer to take a look, thanks.

@LeoColomb LeoColomb merged commit c149470 into YOURLS:main Mar 4, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgw dgw dgw approved these changes

@LeoColomb LeoColomb LeoColomb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@suryatanjung @dgw @LeoColomb