Putting users in DB #1678
Draft
Putting users in DB #1678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That looks interesting, I'll check that in depth Did you check #1255 as referred to in the Roadmap? |
|
I had not, but reading it now seems roughly in line with what I'm doing if a bit more complex (I wasn't planning to implement roles). |
This comment was marked as spam.
This comment was marked as spam.
|
Totally awesome. I do think roles are needed for security reasons though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per comment by Ozh on my previous commit, I am going the other direction and removing information about users and their passwords from the config file and putting them in the database. Functionality still needed includes interfaces for adding users and changing one's password.
What do you guys think?