New functionality added & more customization options (SFX) + Folder fix + small fixes #203

Simi5599 · 2023-04-27T23:48:43Z

When pairing a controller from the controller applet an example text was shown. I blanked it and left a comment instead.

Removed the "explain test" from the controller applet

Readme was not consistent with lastest update (the readme featured the password when this feature was removed in previous versions)

Simi5599 · 2023-04-27T23:49:26Z

I also removed from the README.md the password feature because password functionality was removed in a previous build

With this commit i added new functionalities and customizations to uLaunch, more are planned to be implemented in the next future. Features added: - BGM music in the user selection screen - SFX when an user is selected in the user selection screen - SFX when scrolling users in the user selection screen - SFX when scrolling titles in the main menu - SFX when opening the quick menu - SFX when closing the quick menu - SFX when scrolling the quick menu

Simi5599 · 2023-04-28T15:33:20Z

With this commit i added new functionalities and customizations to uLaunch, more are planned to be implemented in the next future.

Features added:

BGM music in the user selection screen
SFX when an user is selected in the user selection screen
SFX when scrolling users in the user selection screen
SFX when scrolling titles in the main menu
SFX when opening the quick menu
SFX when closing the quick menu
SFX when scrolling the quick menu

This features can be used to create better themes for uLaunch.

We may also need to update the theme wifi in order to reflect changes

XorTroll · 2023-04-28T16:30:55Z

I haven't checked this all yet, but I'd suggest you to make separate PRs if you are pushing so many different changes ;)

XorTroll · 2023-04-28T16:31:04Z

Will make this way less messy for both of us

XorTroll · 2023-04-28T16:32:05Z

I'd also suggest you to discuss these changes/TODOs with me since I may not be willing to add certain stuff or would like to do it in a different way (like via Discord server/DMs)

Simi5599 · 2023-04-28T16:34:08Z

Ok, we will discuss my TODO in your discord, now i am pushing a bugfix for an SFX issue on the home.
Sorry for the long pull request, i am not very familiar with github

Now the title select sfx will be triggered only if a button is pressed

Now the theme menu have some sfx when going back or scrolling though the themes

Simi5599 · 2023-04-29T22:25:26Z

Had to put the folder fix in this pr because github does not let me create a new pr

2 issues were fixed: 1) If the user was in a folder and removes every title (from the folder) then an error screen was appearing (title launch error) and the user returns to the home screen 2) If the user moved an item from a folder to the home the item was not respecting it's original position leading then to issues when adding other elements to folders

Simi5599 · 2023-04-30T18:52:50Z

With the last 2 commit i made the folder functionality more reliable, should work perfectly now

http / https auto added + Added the possibility to open directly google without entering the url

Dracrius · 2023-05-30T05:27:22Z

This and the other PR's should get pulled into master as the project seems to have become stale and lacks development. This isn't surprising with no PR's getting accepted in the last 3 years.

I have started working from Simi5599 last commit as the fixes for folders are needed asap as they are completely useless in the current release! I'd love to add my own PR's but if fixes and improvements need to be pre-approved before we even write them you are just stifling innovation. While I do agree each PR should be a single feature or fix since the project is open source you should be open to things being done a different way then you may have done it.

There is no reason not to accept the docker implementation and the Korean translation for instance. This project is the start of the perfect frontend replacement but if others can not contribute it is dead in the water as a LOT of features are missing.

The quick menu will not close when an action is triggered. Still not working with settings and themes menus

XorTroll · 2023-06-06T15:04:59Z

uLaunch/source/cfg/cfg_Config.cpp

@@ -384,6 +384,13 @@ namespace cfg {
        ofs.close();
    }

+    void DeleteRecord(const TitleRecord record){


) { in the function

(sorry if I get too annoying with this details, otherwise I can merge this and change them myself)

no problems, i will change it now according to your style :)

XorTroll · 2023-06-06T15:08:33Z

uMenu/include/ui/ui_QuickMenu.hpp

@@ -5,6 +5,10 @@

 namespace ui {

+    namespace quickmenu_utils{


For a variable like this I'd make it a private static (inside an anonymous namespace in a source file) and then use functions like IgnoreQuickMenuInputs(const u32 count) and ResetQuickMenuInputsToIgnore or whatever for it

XorTroll · 2023-06-06T15:09:06Z

uMenu/include/ui/ui_QuickMenu.hpp

@@ -56,7 +64,12 @@ namespace ui {
            }

            inline void Toggle() {
-                this->on = !this->on;
+                if(ui::quickmenu_utils::quickMenuInputsToIgnore>0){


I'd also make this function not inline anymore, since it's not a trivial thing anymore

changing this :) , you're right

XorTroll · 2023-06-06T15:10:15Z

uMenu/source/ui/ui_Actions.cpp

        HidLaControllerSupportArg arg = {};
        hidLaCreateControllerSupportArg(&arg);
        arg.enable_explain_text = true;
        for(u32 i = 0; i < 8; i++) {
-            strcpy(arg.explain_text[i], "Test explain text");
+            strcpy(arg.explain_text[i], ""); //Controller explain test here


We could make a string for this in the translation JSON actually, maybe myself or in a new PR

In the original switch menu there is not any text if i remember correctly, maybe themes can make advantage of this is some ways but it will be a new functionality

XorTroll · 2023-06-06T15:10:50Z

uMenu/source/ui/ui_Actions.cpp

        if(option == 0) {
            friendsLaShowMyProfileForHomeMenu(uid);
        }
        else if(option == 1) {
+            ui::quickmenu_utils::quickMenuInputsToIgnore=0; //Menu can close if i am logging out


= on assignments (same for the rest of the changes, although not that important)

sorry i did not understood that

XorTroll · 2023-06-06T15:11:45Z

uMenu/source/ui/ui_Actions.cpp

+        }
+        if(open_browser){
+            UL_RC_ASSERT(dmi::menu::SendCommand(dmi::DaemonMessage::OpenWebPage, [&](dmi::menu::MenuScopedStorageWriter &writer) {
+                if(!(std::strstr(url,"http://") || std::strstr(url,"https://"))){ //If the URL does not contain http or https the browser will give en error, so i am automatically addinh http (not every website supports https and if a website supports https it will redirect)


Some comments like this one could be a bit more clear (plus the typos too, again not that big of a deal)

Got it, done :)

XorTroll · 2023-06-06T15:12:19Z

uMenu/source/ui/ui_Actions.cpp

+                    if(std::strlen(url)<493){ //we want to avoid a buffer overflow when using strcat
+                        char http_prefix[]="http://";
+                        char new_url[url_size]="";
+                        std::strcat(new_url,http_prefix);


I feel it might be easier and cleaner to just use std::string for these string operations

XorTroll · 2023-06-06T15:13:18Z

uMenu/source/ui/ui_QuickMenu.cpp

@@ -8,6 +8,10 @@ extern ui::MenuApplication::Ref g_MenuApplication;

 namespace ui {

+    namespace quickmenu_utils{


As mentioned in another comment, I'd make this an anonymous namespace (also keeping the name style for global variables) and modify it with helper functions rather than using externs

XorTroll · 2023-06-06T15:14:04Z

uMenu/source/ui/ui_QuickMenu.cpp

-            // B only valid for toggling off
-            // A = something selected in the menu
-            if(this->on) {
+            if((keys_down & HidNpadButton_L) || (keys_down & HidNpadButton_R) || (keys_down & HidNpadButton_ZL) || (keys_down & HidNpadButton_ZR)) {


Again about the comments, I'd rewrite some of these to be clearer

Simi5599 added 2 commits April 28, 2023 01:20

Removed explain text from controller

de3e36d

Removed the "explain test" from the controller applet

Removed password info

485c395

Readme was not consistent with lastest update (the readme featured the password when this feature was removed in previous versions)

Simi5599 changed the title ~~Removed explain text from controller section + Removed password details from Readme.md~~ New functionality added & more customization options + small fixes Apr 28, 2023

Simi5599 added 3 commits April 28, 2023 18:34

Bugfix on title select sfx

7774eb7

Now the title select sfx will be triggered only if a button is pressed

New SFX Added (Theme Menu)

90798ff

Now the theme menu have some sfx when going back or scrolling though the themes

New SFX Added (Settings Menu)

f96a1d8

Now the theme menu have some sfx when going back or scrolling though the themes

Simi5599 changed the title ~~New functionality added & more customization options + small fixes~~ New functionality added & more customization options (SFX) + small fixes Apr 28, 2023

Folders working

16ec3d3

Simi5599 changed the title ~~New functionality added & more customization options (SFX) + small fixes~~ New functionality added & more customization options (SFX) + Folder fix + small fixes Apr 29, 2023

Simi5599 added 2 commits April 30, 2023 16:54

Using appropriate types for folder management

e3e6cdf

Simi5599 added 2 commits May 1, 2023 22:20

Web browser improvements

5bebeff

http / https auto added + Added the possibility to open directly google without entering the url

Logout SFX

d7f269b

Simi5599 added 2 commits May 30, 2023 16:52

Do not close the quick menu when an action is triggered

ec15d16

The quick menu will not close when an action is triggered. Still not working with settings and themes menus

Do not close the quick menu when closing with B an action

beb1c68

XorTroll reviewed Jun 6, 2023

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

New functionality added & more customization options (SFX) + Folder fix + small fixes #203

New functionality added & more customization options (SFX) + Folder fix + small fixes #203

Simi5599 commented Apr 27, 2023

Simi5599 commented Apr 27, 2023

Simi5599 commented Apr 28, 2023 •

edited

XorTroll commented Apr 28, 2023

XorTroll commented Apr 28, 2023

XorTroll commented Apr 28, 2023

Simi5599 commented Apr 28, 2023

Simi5599 commented Apr 29, 2023

Simi5599 commented Apr 30, 2023

Dracrius commented May 30, 2023 •

edited

XorTroll Jun 6, 2023

Simi5599 Jun 26, 2023

XorTroll Jun 6, 2023

XorTroll Jun 6, 2023

Simi5599 Jun 26, 2023

XorTroll Jun 6, 2023

Simi5599 Jun 26, 2023

XorTroll Jun 6, 2023

Simi5599 Jun 26, 2023

XorTroll Jun 6, 2023

Simi5599 Jun 26, 2023

XorTroll Jun 6, 2023

XorTroll Jun 6, 2023

XorTroll Jun 6, 2023

		@@ -8,6 +8,10 @@ extern ui::MenuApplication::Ref g_MenuApplication;

		namespace ui {

		namespace quickmenu_utils{

New functionality added & more customization options (SFX) + Folder fix + small fixes #203

Are you sure you want to change the base?

New functionality added & more customization options (SFX) + Folder fix + small fixes #203

Conversation

Simi5599 commented Apr 27, 2023

Simi5599 commented Apr 27, 2023

Simi5599 commented Apr 28, 2023 • edited

XorTroll commented Apr 28, 2023

XorTroll commented Apr 28, 2023

XorTroll commented Apr 28, 2023

Simi5599 commented Apr 28, 2023

Simi5599 commented Apr 29, 2023

Simi5599 commented Apr 30, 2023

Dracrius commented May 30, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Simi5599 commented Apr 28, 2023 •

edited

Dracrius commented May 30, 2023 •

edited