-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[23_27] Change std-arc to counterclockwise #1842
Conversation
Maybe useful reference: #1038 |
Here is the test doc, with or without this pull request, the rendering of the arc is different. Please think about compatibility! Must we break the compatibility?
|
One solution is to introduce a new data type, for example we can name it std2-arc. std-arc is clockwise, and std2-arc is counterclockwise. Then in the new version we can generate std2-arc by default when drawing an arc. This is a solution. I'm wondering if there is a better solution. |
@da-liii I add a new type called |
Is there a better and shorter name for |
I've abstracted the common part into a helper function. |
@da-liii I've added sector counterclockwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested on Linux
What
Change the arc direction of std-arc to counterclockwise
Why
It's more common for math workers.
How to test your changes?
Use mogan's arc drawing function