New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rewrite having skip calc expr #287

Open

kosmgco wants to merge 1 commit into XiaoMi:dev from kosmgco:feat/having

kosmgco commented Aug 3, 2021

What problem does this PR solve?

SOAR对于having语句的rewrite处理聚合函数存在问题 #63

What is changed and how it works?

RewriteHaving 时判断 having 的各个条件是否是计算列，如果为计算列则不替换到 where 子句

Check List

Tests

Unit test
go test -run ^TestRewriteHaving$ github.com/XiaoMi/soar/ast -test.v -count=1
Integration test
Manual test (add detailed scripts or steps below)
No code

Code changes

Has exported function/method change
Has exported variable/fields change
Has interface methods change
Has persistent data change

Side effects

Possible performance regression
Increased code complexity
Breaking backward compatibility


          rewrite having skip calc expr

b23d78d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment