Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tbb::affinity_partitioner according to documentation #338

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

FabienPean-Virtonomy
Copy link
Collaborator

@DrChiZhang
Copy link
Collaborator

How about the improvement of this modification?

@FabienPean-Virtonomy
Copy link
Collaborator Author

I assume close to nil. Previous version was creating an affinity_partitioner for each translation unit which is pretty close to this. This may have had an impact when the affinity partitioner object is used multiple times in different algorithms within the same source file. I just tried to follow the documentation for the recommended use of this feature.

If we trust solely the CI (which is not really representative of actual load because of using 2/3 cores only) then it seemingly gets worse for macOS based on a single sample

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants