Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes decomps already in thewalrus #739

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

nquesada
Copy link
Collaborator

@nquesada nquesada commented May 4, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • [X ] All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    test directory!

  • [X ] All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • [X ] Ensure that the test suite passes, by running make test.

  • [ X] Ensure that code and tests are properly formatted, by running make format or black -l 100 <filename> on any relevant files. You will need to have the Black code format installed:
    pip install black.

  • [ X] Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • [X ] The Strawberry Fields source code conforms to
    PEP8 standards.
    We check all of our code against Pylint.
    To lint modified files, simply pip install pylint, and then
    run pylint strawberryfields/path/to/file.py.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
A number of decompositions already exist in thewalrus that are better tested and perform better. This will work only when XanaduAI/thewalrus#363 is merged.
Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@nquesada nquesada changed the title Removes decomps from thewalrus Removes decomps already in thewalrus May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant