-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quadrature repr in CircuitComponent #399
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #399 +/- ##
===========================================
- Coverage 87.63% 87.61% -0.02%
===========================================
Files 81 81
Lines 6129 6154 +25
===========================================
+ Hits 5371 5392 +21
- Misses 758 762 +4
Continue to review full report in Codecov by Sentry.
|
Except for the two TODOs rename thing, this PR looks nice to me! (happy to move the quadrature thing into CircuitComponent directly. Please fix them and it is good to go! |
Co-authored-by: Yuan YAO <16817699+sylviemonet@users.noreply.github.com>
@elib20 can I get an approval when you have a minute? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for waiting! I have a few questions.
Co-authored-by: Eli Bourassa <53090166+elib20@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for addressing the comments! I'm approving, but left a couple remaining comments/questions to be addressed in future.
Adds
quadrature
representation at the level of CircuitComponent: since it's a single-wire operation it always exists.Simplifies having to check for representation type when extracting data by creating a common abstraction
scalar
which meansc
for Bargmann andarray
for Fock, anddata
which istriple
for Bargmann andarray
for Fock. This way we simplify lots of uselessif
s andisinstance
checks.