Adding/fixing gates in lab_dev transformations #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #398 +/- ##
===========================================
+ Coverage 87.43% 87.65% +0.22%
===========================================
Files 81 81
Lines 6135 6142 +7
===========================================
+ Hits 5364 5384 +20
+ Misses 771 758 -13
... and 3 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
|
The Tensorflow test worked for the initial push. The difference to the second is I ran the 'black formatting' and now Tensorflow fails. |
ziofil
reviewed
May 13, 2024
ziofil
reviewed
May 13, 2024
sylviemonet
reviewed
May 13, 2024
sylviemonet
reviewed
May 13, 2024
Co-authored-by: Yuan YAO <16817699+sylviemonet@users.noreply.github.com>
Co-authored-by: Yuan YAO <16817699+sylviemonet@users.noreply.github.com>
sylviemonet
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context:
Fixing mistakes of the Rgate and adding Identity to lab_dev
Description of the Change:
Correcting the Abc triplet of the Rgate from squeezing Abc to rotation Abc and updating the tests. Adding the identity transformation and tests of it.
Benefits:
More (and correct) gates in lab_dev.
Possible Drawbacks:
Related GitHub Issues: