Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opt contraction #397

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Opt contraction #397

wants to merge 16 commits into from

Conversation

ziofil
Copy link
Collaborator

@ziofil ziofil commented May 9, 2024

Context:
At the moment a user has to figure out the optimal path to contract a circuit. This PR introduces a utility that computes the optimal path automatically and allows for custom heuristics.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@ziofil ziofil added the WIP work in progress label May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

Attention: Patch coverage is 17.10037% with 223 lines in your changes are missing coverage. Please review.

Project coverage is 84.41%. Comparing base (680bf64) to head (808eff0).
Report is 2 commits behind head on develop.

Current head 808eff0 differs from pull request most recent head a37cae6

Please upload reports for the commit a37cae6 to get more accurate results.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #397      +/-   ##
===========================================
- Coverage    87.44%   84.41%   -3.04%     
===========================================
  Files           81       82       +1     
  Lines         6142     6403     +261     
===========================================
+ Hits          5371     5405      +34     
- Misses         771      998     +227     
Files Coverage Δ
mrmustard/lab_dev/circuit_components.py 96.13% <100.00%> (ø)
mrmustard/lab_dev/circuits.py 76.78% <18.51%> (-18.67%) ⬇️
mrmustard/lab_dev/opt_contraction.py 15.18% <15.18%> (ø)

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 680bf64...a37cae6. Read the comment docs.

@@ -0,0 +1,13 @@
from mrmustard.lab_dev.opt_contraction import optimal_path, staircase
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delete this file?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep!

@ziofil ziofil added the no changelog Pull request does not require a CHANGELOG entry label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog Pull request does not require a CHANGELOG entry WIP work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants