-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing codecoverage #395
Fixing codecoverage #395
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #395 +/- ##
===========================================
+ Coverage 87.44% 87.63% +0.18%
===========================================
Files 81 81
Lines 6142 6129 -13
===========================================
Hits 5371 5371
+ Misses 771 758 -13
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
I think codecov is wrong.... Tried running tests locally with |
Mmmh interesting.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Context:
A few open PRs are failing because of indirect changes in the coverage of three files, all of which are unrelated to the given PRs.
Here, I either add tests (where I know how to test) or
# pragma: no cover
to the problematic lines