Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: TensorFlow dependency set to ~2.15 #382

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

xvalcarce
Copy link

Context:

See issue #381

Description of the Change:

Restrict TensorFlow dependency to >=2.15 and <2.16.

@SamFerracin
Copy link
Contributor

Hi @xvalcarce ,

Thanks for opening this issue up! :)

Personally, I am not convinced that TF should be restricted to version < x, because in the future we will certainly want to install y > x.

The solution to your issue may be using poetry rather than pip install. In your environment, do

pip install poetry
cd MrMustard
poetry install ...

optionally replace ... with options, like we do in our .github/workflows.

TF is locked to 2.15, so poetry should install 2.15

@xvalcarce
Copy link
Author

Hey @SamFerracin :)

I agree, this is not a long term viable solution, but a simple quick-fix! Instead the codebase should be updated to match TF 2.16, and set this new version as a minimum requirement. This mainly involves using Adam from Keras 3 (as mentioned in the issue) as well as removing the need for tensorflow-macos as explained here. I can propose these changes in a future commit, if you are interested!

About the installation method, if an installation with cloning the repo and using poetry works fine thanks to the lock, I do believe that installing MrMustard with pip install mrmustard should provide a working module.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants