-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor devcontainer 📦 #329
base: develop
Are you sure you want to change the base?
Conversation
{ | ||
"name": "Mr Mustard", | ||
"name": "MrMustard 🌭", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha love it
env.Dockerfile
Outdated
@@ -0,0 +1,40 @@ | |||
# *** Base *** # | |||
FROM python:3.10 AS base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Were we always using 3.10 for docker, or 3.9?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We had 3.9 to match the lowest python version supported by MrMustard but @ziofil uses 3.10 more often inside devcontainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it were for me I'd use 3.12! Maybe now 3.11 is supported too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the devcontainer definition so it will build with 3.10 by default, but you can specify another version if you please. To do this, just have the MRMUSTARD_PYTHON_VERSION
environment variable set locally before building+opening the devcontainer (default will be 3.10).
Some notes:
- I feel like VS Code always refreshes something before building, so I'd put it in your
~/.bashrc
, ~/.zshrc` or whatever you use to be safe - We can't build with 3.12 because tensorflow fails to install 🙃
@ziofil, I've readded oh-my-zsh to the container as default terminal |
# Conflicts: # .devcontainer/Dockerfile # .devcontainer/post-install.sh
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #329 +/- ##
========================================
Coverage 87.61% 87.61%
========================================
Files 81 81
Lines 6154 6154
========================================
Hits 5392 5392
Misses 762 762 Continue to review full report in Codecov by Sentry.
|
Context:
Doing some housekeeping here on the devcontainer side.
Description of the Change:
juliacall
, meaning there is no need for passing the optionalJULIA_INSTALL
arg todocker build
.MRMUSTARD_PYTHON_VERSION
env-var set in their local environment to dictate which python version the dev container will be built with. When unset, the default value is 3.10. I'd suggest doing this in yourbashrc/zshrc/whatever-rc
to ensure it's always set and therefore picked up by VS CodeBenefits:
Possible Drawbacks:
None