Fix: Missing Headers - Linker Errors [DO NOT MERGE] #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some of the changes here remove JSON dumps from important logging lines. Can you rework it so those dumps remain? |
dangell7
changed the title
RichardAH
reviewed
Mar 27, 2024
| @@ -171,8 +171,7 @@ STValidation::STValidation( | |||
| { | |||
| if (checkSignature && !isValid()) | |||
| { | |||
| JLOG(debugLog().error()) << "Invalid signature in validation: " | |||
| << getJson(JsonOptions::none); | |||
| JLOG(debugLog().error()) << "Invalid signature in validation"; | |||
There was a problem hiding this comment.
I still want the hex if not the json dumped under this condition, otherwise we wouldnt know which validation/signature was invalid if we had to debug with this
There was a problem hiding this comment.
I agree I marked it as DNM. Still figuring out the solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Context of Change
Type of Change
.gitignore, formatting, dropping support for older tooling)API Impact
libxrplchange (any change that may affectlibxrplor dependents oflibxrpl)