Allows Debian Jessie users to play with rippled

[mffrench]

As a lucky Debian Jessie users, some of us are missing an important stack to play with rippled from the sources : gcc5. Instead of hacking our working station (and potentially break it) we can setup a rippled development environment thanks docker.

Basic idea: being able to edit rippled source files with our favorite tools and then build, test and run rippled inside docker containers.

Let me know if you see any things to be improved in order to accept this pull req.

Cheers,

Mathilde

[codecov-io]

Current coverage is 65.45% (diff: 100%)

Merging #1935 into develop will decrease coverage by <.01%

@@            develop      #1935   diff @@
==========================================
  Files           698        698          
  Lines         49745      49745          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
- Hits          32562      32559     -3   
- Misses        17183      17186     +3   
  Partials          0          0          

Powered by Codecov. Last update 4d7b1a3...309c36e

[nbougalis]

Thank you for this work Mathilde. It needs a little bit of polishing before it's merged, but this is amazing.

I've left some comments that I'd like to see addressed before we proceed. I'll likely add some more small comments over the weekend.

[nbougalis]

It would be great if this could be reworded to be a little more formal. Perhaps:

Setup a working rippled development and testing environment inside a Docker container, without the need to install tools and libraries (such as gcc5) on Debian Jessie.

I'm not very familiar with Docker, and I'm curious, will this particular Docker build work only on Debian Jessie hosts? How easy would it be for this container to run, say, on other Linux distributions, such as Ubuntu, Fedora, CentOS or RHEL hosts?

[mffrench]

I just described my particular use case as I think most Linux distros are using gcc5 now. But you're right : this should work on any system where docker is installed - any Linux distro but also OSX or Windows (still need to be tested and validated). Will proceed changes as you suggest.

[nbougalis]

This same comment appears multiple times in this document.

[nbougalis]

Prefer "What do you need to use this container?" instead of "What do you need to play ?" Similarly, below, in the "How to play ?" prefer "How to use" instead.

[nbougalis]

rippled uses tcp; is there a reason why this is udp?

[mffrench]

Here I reused same EXPOSE definitions as in Builds/Docker/Dockerfile-testnet without checking doc in deep. I will remove this UDP expose but I'm curious now : why is there this udp expose in the Dockerfile-testnet ?

[wilsonianb]

@mffrench I've been in the habit of making a static build of rippled in a Docker container and running rippled locally (not in Docker).

Dockerfile:
https://gist.github.com/wilsonianb/57c67bc059d74455de13f9689050d6b1

I mount my local source files when I run the container, and a statically linked binary is outputted to build/rippled.

Would something like that work for you?

[mffrench]

@wilsonianb: originally I wanted to setup and play with a multi rippled nodes network thanks docker-compose and so I didn't get the idea to make a static build.
This solution will work for sure for standalone rippled and unit tests. In the other hand it seems to me docker could be helpful if we want simulate a multi rippled network on the same host.
Let me know what you think about...

[wilsonianb]

@mffrench Are you wanting multi-node networks based on custom builds of rippled? If not, you could simply use the official rpm package in a CentOS Docker base image:
https://ripple.com/build/rippled-setup/#installation-on-centosred-hat-with-yum
There is also a nightly package available built from the rippled develop branch (use ripple-nightly instead of ripple-stable when running yum install).
Note that the rpm install docs instruct you to run rippled with systemd (systemctl), but you may run into issues trying to use systemd in a Docker container:
moby/moby#7459

[mffrench]

@wilsonianb yep ! I wanted to learn and play with rippled from source to multi nodes network on my debian :) I was thinking that could be also useful for the community and so I did this pull request but if you prefer I can push these tools in a separate git repository to keep this one safe from not so useful code. Let me know what you prefer ;)

[mffrench]

@nbougalis : I did some changes on the README and RippledRunner/Dockerfile following your advices. Let me know if you see any other improvements to be done.

[mffrench]

@wilsonianb I added scons options to enable static build depending needs (also documented on readme). Let me know if you have other advices and use cases !

[nbougalis]

Thanks for addressing my comments @mffrench. Now that we got 0.50.0 out the door, we will be putting a 0.60.0-b1 together, and we will take a closer look as we consider which PRs will be included.

[vinniefalco]

This needs to be squashed

[nbougalis]

Sorry we didn't get to this earlier and allowed it to bit-rot, @mffrench. I'm going to close it, since, as is, it's just not applicable.

However, I'd be very interested in seeing a revived version, whether docker or vagrant based, based off the latest develop. If you're interested in doing that, that'd be awesome.