feat!: find default IP segment file at the location of the executable #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charSLee013
reviewed
Jul 1, 2023
task/ip.go
Outdated
| if err != nil { | ||
| log.Fatal(err) | ||
| } | ||
| return filepath.Dir(sym) + "/ip.txt" |
There was a problem hiding this comment.
路径拼接改为 filepath.Join(sym, defaultInputFile) 在兼容性会不会更好一点？
task/ip.go
Outdated
Comment on lines
177
to
180
| } else { // 从文件中获取 IP 段数据 | ||
| if IPFile == "" { | ||
| IPFile = defaultInputFile | ||
| IPFile = getDefaultInputFile() | ||
| } |
There was a problem hiding this comment.
限制住IP文件只能跟执行文件在一起可能不太友好，可以先从当前工作目录下寻找defaultInputFile，如果找不到再考虑执行文件所在的目录下
下面是我粗略的改法，仅供参考
} else { // 检查默认目录下是否存在IP文件
if IPFile == "" {
// 优先检查工作目录下的IP文件
if _,err:= os.Stat(defaultInputFile); err != nil {
IPFile = getDefaultInputFile();
} else {
IPFile = defaultInputFile
}
}
|
已修改。没学过 golang，不太会写😂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
May fix #372.