Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

line break error messages #297

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

tylervick
Copy link
Member

Suggested change from @Hsilgos

#155

@tylervick tylervick linked an issue Oct 21, 2022 that may be closed by this pull request
@@ -344,6 +344,7 @@ struct HTMLTemplates

.activity.activity-assertion-failure > p {
color: red;
white-space: pre-wrap;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I wrote in the ticket this approach is good workaround, but not perfect anough.
I think that it's better to do the following thing:

Create another style with white-space:

  .activity.activity-assertion-failure > p {
    color: red;
  }

  .activity.activity-assertion-failure-details > p {
    white-space: pre-wrap;
  }

And add this style only to the row with details. For example pice from our generated HTML:

</div><div class="activity activity-user-created activity-assertion-failure ">
  <p class="list-item">
    <span style="margin-left: 20px" class="padding"></span>
    <span class="icon left drop-down-icon" onclick="toggle(this, 'C8AD9FF1-F9DC-4052-A00E-411217BAF33A')"></span>
    Then SDK engine is created successfully (-1666537987.83s)
    <span class="icon paperclip-icon" style="display: none"></span>
  </p>
  <div id="attachments-C8AD9FF1-F9DC-4052-A00E-411217BAF33A" class="attachments">
      
  </div>
  <div id="activities-C8AD9FF1-F9DC-4052-A00E-411217BAF33A" class="sub-activities">
      <div class="activity activity-assertion-failure activity-assertion-failure-details no-drop-down">
  <p class="list-item">
    <span style="margin-left: 48px" class="padding"></span>
    <span class="icon left drop-down-icon" onclick="toggle(this, '47F4ACD1-F2CE-4CDD-BF08-21A61B037260')"></span>
    Assertion Failure at sdkengine.feature:56:
    XCTAssertNotNil failed - No exception is expected too be thrown (0.00s)
    more of text, etc...
    <span class="icon paperclip-icon" style="display: none"></span>
  </p>
  <div id="attachments-47F4ACD1-F2CE-4CDD-BF08-21A61B037260" class="attachments">

@sonarcloud
Copy link

sonarcloud bot commented Feb 3, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Line breaks in results
2 participants