Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spike: Adding screenshot flow for the start of each test #114

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

amleszk
Copy link
Contributor

@amleszk amleszk commented Nov 10, 2018

@TitouanVanBelle As I suggested here #105 I wanted a way to see all screenshot attachments for failing UI tests. I added new HTML inserted string at the start of each test to show some small screenshots inline. This we help diagnose failures in UI tests with less clicking to expand.

I also added accumulateHTMLAsString to remove the number of repeated reduce calls

@amleszk amleszk changed the title Adding screenshot flow for the start of each test Spike: Adding screenshot flow for the start of each test Dec 8, 2018
@cmarchal
Copy link

Feature I was looking for, thanks !

I've just added a OnClick method at TestScreenshotFlow file - line 52 in order to display the screenshot in the right panel.

onclick=\"showScreenshot('[[FILENAME]]')\"

@jordan-romeroporter-earnin

Is this usable still?

@amleszk
Copy link
Contributor Author

amleszk commented Jan 7, 2020

I will fix the conflicts - should still be usable

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants