Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Larus driver #1423

Merged
merged 1 commit into from
May 14, 2024
Merged

Add Larus driver #1423

merged 1 commit into from
May 14, 2024

Conversation

Simsys
Copy link
Contributor

@Simsys Simsys commented May 8, 2024

Larus is just another open source initiative to provide low cost, high performance avionics to glider pilots. No connection has yet been provided for the XCSoar software. This is now to be changed.

This driver was originally created by August2111 for his XCSoar fork Opensoar. It has now been ported back to XCSoar.

Information about the project: Larus Github-Page
The devices can be ordered: SteFly
Specification of the NMEA protocol: Larus NMEA specification

Thank you for your support

@Simsys Simsys requested a review from a team as a code owner May 8, 2024 12:43
@lordfolken
Copy link
Contributor

lordfolken commented May 8, 2024

HI,
Please update this to our code style.
https://xcsoar.readthedocs.io/en/latest/policy.html#code-style
For instance:

  • Please correct all the code comments
  • Licence as in all other files
  • proper commit message
  • remove the asciii art
  • remove commented code
  • remove "TODOs"
  • news.txt

@Simsys
Copy link
Contributor Author

Simsys commented May 12, 2024

Thank you for the constructive feedback. I have tried to incorporate all points.

@lordfolken
Copy link
Contributor

There seems to be a build failure on windows, due to wchar.

This commit adds a driver for Larus devices to XCSoar. The following
values are transferred from the sensor box to XCSoar:
- current attitude: roll, pitch and yaw angle
- battery voltage
- total energy variometer
- pressure height
- true airspeed
- wind angle and speed

In addition, some setting parameters can be exchanged bidirectionally:
- MacCready
- ballast
- bugs
- QNH

Documentation https://github.com/larus-breeze/doc_larus
Emulator https://github.com/larus-breeze/sw_tools
@Simsys
Copy link
Contributor Author

Simsys commented May 13, 2024

build failure on windows fixed

@lordfolken lordfolken merged commit 90eb018 into XCSoar:master May 14, 2024
8 of 9 checks passed
@Scumi
Copy link
Contributor

Scumi commented May 14, 2024

I suggest adding unit tests like for every other device driver.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants