Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new infobox showing last turn average. #1393

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GeorgeDowning20
Copy link
Contributor

This looks at the time to complete the last turn and then uses that time to calculate an average. This stops the aliasing that you get when in an uneven core, doing 20s turns. similar to clearnav.

thoughts on the idea?

@lordfolken
Copy link
Contributor

I'm sorry no one replied to you. It was marked as a draft and I didn´t really see it.
@bomilkar you are on top of this code at the moment. Do you see merit?

@bomilkar
Copy link
Contributor

Is there an Issue related to this PR?
I'd like to understand why 20s average is better than 30s or 10s ?
My personal preference is to compare the 30s average to the climb performance since the beginning of the thermal. That helps me to decide should I continue or should I move on. Often times I regret the last (couple of) cycles because they weren't worth the time. But all that doesn't depend on the average being calculated over a fixed time vs. one full circle (more or less).

@GeorgeDowning20
Copy link
Contributor Author

GeorgeDowning20 commented Apr 30, 2024

Is there an Issue related to this PR? I'd like to understand why 20s average is better than 30s or 10s ? My personal preference is to compare the 30s average to the climb performance since the beginning of the thermal. That helps me to decide should I continue or should I move on. Often times I regret the last (couple of) cycles because they weren't worth the time. But all that doesn't depend on the average being calculated over a fixed time vs. one full circle (more or less).

20s isn’t necessarily better. The idea is the time constant shouldn’t be fixed. Instead it is constantly adjusted to the time of your last turn.

If you are not properly centered (eg in a gaggle) you sometimes get aliasing where one side of the thermal the 30s average reads 4knts and on the other side 3knts. For example if you are in the “good bit” doing say 20s turns, the 30s average includes the good bit twice and the bad bit once, hence the averager over reads the true climb rate. I personally alway find I look at the averager once a turn, often in the strongest bit, but this isn’t always perfect indication of my climb rate. Like wise in the opposite respect you might be fooled by the averages out of a perfectly good thermal.

@bomilkar
Copy link
Contributor

bomilkar commented May 1, 2024

I understand your point, but I don't agree with what you are proposing. Admittedly, that's my opinion, therefor I suggest you open an Issue to discuss the arguments.

I find only very few thermals are "round enough" that your proposal would actually make a noticeable difference to my decision making. When I look at the flight trail while circling the "good" parts aren't always in the same sector of the circles. So, you can add yet another InfoBox, but is going make a difference. Not in my opinion.
Maybe one alternative I can think of: modify the "TC 30s" InfoBox such that instead of a fixed period of 30 sec make that a parameter in the Gauges->Vario panel, with the choices of 10s, 20s, 30s, 40s, and limit to one full circle while circling. Be aware: "TC 30s" also works in cruise. Please also explain the suggested behavior in corner cases, e.g. during the first circle, very wide circles, in cruise, ... And please discuss all this in an Issue before jumping to an implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants