Add test of laguage name. #1026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current generated tests from the data folder check for the report values but not if the the correct laguage was identified. The problem here is if the wrong language is identified but by luck the counts match, the tests wont catch that. Example: lets say we have a zsh.zsh file that tokei thinks is a bash script. Given how simillar they are, the counts will likely be correct even if the extesion is misenturpreted, but the report produced by tokei will put the counts under the wrong laguage lable. A more tricky example is that of ruby_env which relys on the shebang and the `/usr/bin/env ruby` which is less obvious then some other forms html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current generated tests from the data folder check for the report values but not if the the correct laguage was identified. The problem here is if the wrong language is identified but by luck the counts match, the tests wont catch that.
Example:
lets say we have a zsh.zsh file that tokei thinks is a bash script. Given how simillar they are, the counts will likely be correct even if the extesion is misenturpreted, but the report produced by tokei will put the counts under the wrong laguage lable.
A more tricky example is that of ruby_env which relys on the shebang and the
/usr/bin/env rubywhich is less obvious then some other forms htmlThis test was suggested as a followup of this other PR:
#1025