Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibilty with Qt6 #346

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Conversation

astrofrog
Copy link
Member

Overview

@Carifio24 I tested out your Qt6 fix suggested in #343 and it works fine when using PyWWT inside glue, so from my perspective, this is a sufficient fix.

Checklist

  • Changed code has some test coverage (or justify why not)
  • Changes in functionality documented (or justify why not)

@astrofrog
Copy link
Member Author

I don't understand the CI setup well enough to be able to add a CI job with PyQt6

@codecov
Copy link

codecov bot commented Feb 16, 2023

Codecov Report

Merging #346 (40118e8) into master (4ae8627) will decrease coverage by 0.01%.
The diff coverage is 83.33%.

❗ Current head 40118e8 differs from pull request most recent head 9878543. Consider uploading reports for the commit 9878543 to get more accurate results

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
- Coverage   56.17%   56.16%   -0.01%     
==========================================
  Files          25       25              
  Lines        2836     2838       +2     
==========================================
+ Hits         1593     1594       +1     
- Misses       1243     1244       +1     
Impacted Files Coverage Δ
pywwt/qt.py 69.59% <83.33%> (-0.24%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pkgw
Copy link
Contributor

pkgw commented Feb 21, 2023

I'll see if I can add a CI job although I might not get to it super promptly. If this is sufficiently urgent I'd be OK with merging now and mopping that up later.

@astrofrog
Copy link
Member Author

@pkgw - it would be nice to have this in soon as currently I am not able to use glue-wwt correctly on native Python installations on ARM macs (only PyQt6 is supported), but I'll leave it up to you whether to merge now/later.

@pkgw pkgw merged commit 2a9c816 into WorldWideTelescope:master Feb 22, 2023
@pkgw
Copy link
Contributor

pkgw commented Feb 28, 2023

OK, this has been released in 0.18.1.

@astrofrog
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants