Address #309 #310
Merged
Address #309 #310
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresss WorldWideTelescope#309 the straightforward way. Slow operations can hold up the Qt mainloop enough that the backend convinces itself that the app has become nonresponsive. Note that for the ipywidgets and JupyterLab app backends, the liveness testing is done in the JS frontend code, which really ought to not suffer from this possibility. So those deadlines are staying at their current values, for now.
This is probably going to bite us in other places in the pipeline, but let's make a minimal intervention and see how far we can get.
Codecov Report
@@ Coverage Diff @@
## master #310 +/- ##
==========================================
+ Coverage 59.38% 59.39% +0.01%
==========================================
Files 24 24
Lines 2489 2490 +1
==========================================
+ Hits 1478 1479 +1
Misses 1011 1011
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Address #309 just by bumping out the app liveness deadline.
Also fix an error caused by upgrading to Astropy 4.3, which I just noticed.
Checklist