S138 bulk connection instructions #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aperez-worklytics
approved these changes
Dec 21, 2022
| default = {} | ||
|
|
||
| # TODO: fix these validations; logically correct, but Terraform doesn't allow validation conditions | ||
| # to depend on values of other variables |
There was a problem hiding this comment.
FYI if you want to include the link of the issue to support this on their GH -> hashicorp/terraform#25609
| per_setting_instructions_text = length(var.settings_to_provide) > 0 ? "\n${join("\n", tolist(local.per_setting_instructions))}" : "" | ||
| } | ||
|
|
||
| resource "local_file" "todo-worklytics-connection" { |
There was a problem hiding this comment.
This is already present in worklytics-psoxy-connection module; not sure if intended or it is duplicated
There was a problem hiding this comment.
yeah, it's a more general case. the other one has a url param that's not relevant for the bulk case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features
Change implications