Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor the WP_Block::$attributes dynamic property #6500

Open
wants to merge 19 commits into
base: trunk
Choose a base branch
from
Open

Refactor the WP_Block::$attributes dynamic property #6500

wants to merge 19 commits into from
+340 −9

Commits on May 1, 2024

  1. Commit WIP.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 1, 2024
    Configuration menu
    Copy the full SHA
    230bc80 View commit details
    Browse the repository at this point in the history

  2. Add missing magic methods.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 1, 2024
    Configuration menu
    Copy the full SHA
    f5f375e View commit details
    Browse the repository at this point in the history

Commits on May 3, 2024

  1. Implement the check_if_public_class_property() method.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1344d95 View commit details
    Browse the repository at this point in the history

  2. Correctly populate attributes when accesing the $attributes class pro… 

    …perty within the class.
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1bfce1c View commit details
    Browse the repository at this point in the history

  3. Fix CS.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 3, 2024
    Configuration menu
    Copy the full SHA
    c45d191 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Fix the __unset method (it should use wp_trigger_error()). 

    Update docblockks.
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 6, 2024
    Configuration menu
    Copy the full SHA
    91076f3 View commit details
    Browse the repository at this point in the history

  2. Add unit tests to cover the magic methods.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f43083e View commit details
    Browse the repository at this point in the history

  3. Fix the tests.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 6, 2024
    Configuration menu
    Copy the full SHA
    c12fcd6 View commit details
    Browse the repository at this point in the history

  4. Fix the tests.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 6, 2024
    Configuration menu
    Copy the full SHA
    dc02a5a View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Fix failure messages.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0fbf4a1 View commit details
    Browse the repository at this point in the history

  2. Fix description.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f2ca964 View commit details
    Browse the repository at this point in the history

  3. Fix inline comment.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 7, 2024
    Configuration menu
    Copy the full SHA
    53f5454 View commit details
    Browse the repository at this point in the history

  4. Small refactoring.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 7, 2024
    Configuration menu
    Copy the full SHA
    2754232 View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Emulate how the WP_Block::$attributes property used to work before.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 8, 2024
    Configuration menu
    Copy the full SHA
    5c42a11 View commit details
    Browse the repository at this point in the history

  2. Fix typo.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 8, 2024
    Configuration menu
    Copy the full SHA
    334ab9b View commit details
    Browse the repository at this point in the history

  3. Fix phpdoc block.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 8, 2024
    Configuration menu
    Copy the full SHA
    7354da4 View commit details
    Browse the repository at this point in the history

  4. Fix the comment.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 8, 2024
    Configuration menu
    Copy the full SHA
    e147f10 View commit details
    Browse the repository at this point in the history

  5. Add more tests.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2aa85f7 View commit details
    Browse the repository at this point in the history

Commits on May 9, 2024

  1. Mark the property as read-only.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed May 9, 2024
    Configuration menu
    Copy the full SHA
    2fa7ffd View commit details
    Browse the repository at this point in the history