Changes occurrences of Cancelled to Canceled #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like I'm unable to apply any labels such as Components here. Can I be added as a contributor, please? |
|
I think we wanted this to only change the instances a user will see, so that we don't need to migrate statuses or worry about other edge cases. Can you update the PR to so that it only changes "cancelled" in user-facing strings? (and you should have gotten an invite to be a contributor, let me know here or on slack if you have any questions!) |
CdrMarks
added
the
[Component] WCPT
|
@ryelle I've update the PR. Let me know if you see any other changes that need to be made. |
|
Fixes #553 |
|
It still seems like there are some code strings which are being altered, we should fix those before merging to avoid unnecessary breakage. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes occurrences of Cancelled to Canceled, regardless case.
Fixes 553.
After implementing this, it will be necessary to update existing WordCamp statuses from
wcpt-cancelledtowcpt-canceled. Public statuses may also need to be changed.