New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add WPTV URL meta field #143
Conversation
e49681f
to
b56db01
Compare
9f5f754
to
b56db01
Compare
@renintw could you please add some testing instructions? 🙏 |
@adamwoodnz I've updated it in the description. Some more setting info in case you need it! |
0d3c5c3
to
98fa6f6
Compare
ce82c09
to
56d4948
Compare
@@ -569,6 +580,18 @@ public function render_meta_boxes( $post ) { | |||
<input type="text" name="location" id="location" class="regular-text wide" value="<?php echo esc_attr( $location ); ?>"> | |||
</label> | |||
</p> | |||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an extra tag here
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 Works for me, great work!
Just one comment inline
Fixes #1003
This PR
View recording
link to the modal. The URL would be to the wordpress.tv item entered in the meta field.Screenshots
Edit Screen
Meeting List
Modal
List
List items would not show in Learn, but might show in other places. e.g., https://make.wordpress.org/meetings/
ICS Import
Testing instructions
meeting-calendar
and activate it./wp-admin/edit.php?post_type=meeting
. There should be three default meetings.WPTV URL
./online-workshops/
. Otherwise, create a post and add a meeting block.View Recording
should be there.List
, in devTools -> Element, searchwporg-meeting-calendar__list-event-copy
, and unclick thedisplay: none
(in Learn, it was set invisible),View Recording
should be there.iCal
, and import to your calendar, should see all three meetings are added and show the corresponding info.TODO
Fix PHPCS errors - WP PHPCS is updated to PHP8.0+. Some function usage standards have changed.Update
PR to fix the issue is opened: #144Update
Closed #144 (See reason there) and fixed in Fix PHPCS error.