Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix scroll on moving blocks #3268

Merged
merged 1 commit into from
Oct 31, 2017
Merged

Fix scroll on moving blocks #3268

merged 1 commit into from
Oct 31, 2017

Conversation

youknowriad
Copy link
Contributor

Quick fix to a regression introduced by #3147 because it changed the scrollable container

also related to #2959

Testing instructions

  • Test that moving the blocks keep the block at the same position (same for multiselection)

@youknowriad youknowriad self-assigned this Oct 31, 2017
aduth
aduth approved these changes Oct 31, 2017
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolves the general issue. I note that scrolling only takes effect after the second "Move Down" click, which wasn't always the case, but I don't know that is specifically related to the changes from #3147

@youknowriad youknowriad merged commit b57b907 into master Oct 31, 2017
@youknowriad youknowriad deleted the fix/scrollable-container branch October 31, 2017 16:39
@mtias
Copy link
Member

mtias commented Oct 31, 2017

We need some tests for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees

@youknowriad youknowriad

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@youknowriad @mtias @aduth