Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

curl.after_send hook: pass the $handle as parameter #679

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

jrfnl
Copy link
Member

@jrfnl jrfnl commented Feb 7, 2022

Fixes #220

@jrfnl jrfnl removed this from the 2.1.0 milestone Feb 28, 2022
@jrfnl
Copy link
Member Author

jrfnl commented Feb 28, 2022

Before we actually action this, we should have a good look at the security implications of allowing access to the $handle (not just here).

@schlessera
Copy link
Member

The curl.before_send already provides access to the $handle, so it is questionable in the end whether this would have any security implications that aren't already present anyway.

So we need to consider the following:

  • What would be an extra issue with the "after send" access that wouldn't already be problematic with the "before send"?
  • Is the "before send" already problematic enough that we need to act on it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing Available Hook in Doc and Missing Hook Parameter
3 participants