Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature upload #567

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

Feature upload #567

wants to merge 7 commits into from

Conversation

pbearne
Copy link

@pbearne pbearne commented Sep 28, 2021

Pull Request Type

  • [ X] I have checked there is no other PR open for the same change.

This is a:

  • Bug fix
  • [X ] New feature
  • Code quality improvement

Context

Detailed Description

This is an update/refreshed version of https://github.com/soulseekah/Requests/tree/feature-upload

I have also added a helper function
Requests::add_files_to_body() to provide simplar way to add files to a body object

Quality assurance

  • [ X] This change does NOT contain a breaking change (fix or feature that would cause existing functionality to change).
  • [ x] I have commented on my code, particularly in hard-to-understand areas.
  • [x ] I have added unit tests to accompany this PR.
  • [x ] The (new/existing) tests cover this PR 100%.
  • [x ] I have (manually) tested this code to the best of my abilities.
  • [ x] My code follows the style guidelines of this project.

Documentation

For new features:

  • [x ] I have added a code example showing how to use this feature to the examples directory.
  • [x ] I have added documentation about this feature to the docs directory.
    If the documentation is in a new markdown file, I have added a link to this new file to the Docs folder README.md file.

#289

soulseekah and others added 7 commits February 11, 2018 23:37
@soulseekah
Initial cURL file upload support
3ebc94a 
Inspired by WordPress#289
@soulseekah
Initial fsockopen transport upload support
1b60f14 
Next up: test multiple files, request_multi

See WordPress#289
@soulseekah
Introduce Requests_File for simple file uploads
a47689d
@pbearne
Merge remote-tracking branch 'remotes/origin/develop' into feature-up…
3633eba 
…load

# Conflicts:
#	src/Exception/File.php
#	src/File.php
#	src/Transport/Curl.php
#	src/Transport/Fsockopen.php
#	tests/Transport/Base.php
#	tests/phpunit.xml.dist
@pbearne
fixed test/code
6d92c08 
Added helper function Requests::add_files_to_body() to add files to body
@pbearne
fixed test/code
0991390 
Added helper function Requests::add_files_to_body() to add files to body
@pbearne
Added example and docs
7cac250
@gdarko
Copy link

gdarko commented Dec 14, 2021

Why this still isn't merged? Such useful features...

@jrfnl
Copy link
Member

jrfnl commented Dec 14, 2021

@gdarko It's kind of hard to review code which is littered with unaddressed (automated) comments....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Focus: File handling
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@pbearne @gdarko @jrfnl @schlessera @soulseekah