[WT-536] Removed package vulnerabilities #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # client/package-lock.json # client/package.json
# Conflicts: # client/package-lock.json # client/package.json
ben16williams
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updated and removed vulnerable (unused) packages from client and server
package.json.Removed the following unused package from
server/:axios: was unusedRemoved the following unused packages from
client/:@emotion/react@emotion/styled@mui/labaxios: is now unuseddaisyuideep-diffreact-tailwind-tableMoved
react-scriptsto dev dependencies.Updated client packages:
@types/nodefrom16.11.41to20.5.8.@mui/x-data-gridfrom5.0.0-beta.5to5.4.1IMPORTANT: What I learned was that the bulk of the vulnerabilities are coming from
react-scripts. However, this is only a dev dependency, and so these vulnerabilities can be ignored (see this thread). To run an appropriate package audit, just donpm audit --omit=dev.Risks
Small chance that one of these packages were being used, but this is unlikely.
Validation
Checked docker container consoles and played around in WonderTix with no found errors (particularly looked at the X-Data-Grid components.
Issue
#536
Operating System
macOS M2