Merge pull request #76 from Wolkabout/bugfix/mappings-copying

Fixed up the bug, so mappings are now properly copied for every device

Author: Ana Vuletić

.pre-commit-config.yaml

@@ -0,0 +1,14 @@
+# See https://pre-commit.com for more information
+# See https://pre-commit.com/hooks.html for more hooks
+repos:
+  - repo: https://github.com/pre-commit/pre-commit-hooks
+    rev: v3.2.0
+    hooks:
+      - id: trailing-whitespace
+      - id: end-of-file-fixer
+      - id: check-yaml
+      - id: check-added-large-files
+  - repo: https://github.com/pre-commit/mirrors-clang-format
+    rev: v10.0.1
+    hooks:
+      - id: clang-format

RELEASE_NOTES.txt

@@ -5,6 +5,9 @@
 
 WolkGateway module for connecting Modbus devices to WolkAbout IoT Platform by communicating with WolkGateway.
 
+**Version 1.1.0**
+	- [BUGFIX] - Copying the mappings is now properly done.
+
 **Version 1.0.2**
     - [IMPROVEMENT] - Added a new version of `MoreModbus` that introduces a lot of small improvements.
 

debian/changelog

@@ -1,5 +1,5 @@
-wolkgatewaymodule-modbus (1.0.2) stable; urgency=medium
+wolkgatewaymodule-modbus (1.1.0) stable; urgency=medium
 
-      * Added a new version of `MoreModbus` that introduces a lot of small improvements.
+      * Copying the mappings is now properly done.
 
- -- Wolkabout ELab <elab@wolkabout.com>  Mon, 8 Aug 2022 00:00:00 +0100
+ -- Wolkabout ELab <elab@wolkabout.com>  Thu, 6 Apr 2023 00:00:00 +0100

modbus/module/ModbusBridge.cpp

@@ -139,7 +139,11 @@ void ModbusBridge::initialize(const std::map<std::string, std::unique_ptr<Device
             }();
 
             const auto device = std::make_shared<more_modbus::ModbusDevice>(key, slaveAddress);
-            device->createGroups(mappings);
+
+            auto mappingsCopy = std::vector<std::shared_ptr<more_modbus::RegisterMapping>>{};
+            for (const auto& mapping : mappings)
+                mappingsCopy.emplace_back(std::make_shared<more_modbus::RegisterMapping>(*mapping));
+            device->createGroups(mappingsCopy);
             modbusDevices.emplace_back(device);
 
             m_deviceKeyBySlaveAddress.emplace(slaveAddress, key);