Unbundle zstd #130
Open
Unbundle zstd #130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also makes it possible to use a system provided Zstd library by specifying the '-DFETCHCONTENT_TRY_FIND_PACKAGE_MODE=ALWAYS' CMake flag. * Projects/CMakeLists.txt: Use FetchContent to make zstd available. Use imported target for link directive. * Libraries/zstd-1.5.0: Delete directory. * Source/Online/online.cpp: Do not include private source. (Online::DecompressData): Replace ZSTD_getErrorString with ZSTD_getErrorName, which is part of the public API.
* Projects/CMakeLists.txt (USE_SYSTEM_LIBS): New option. When defined, use pkg-config to locate the zstd shared library.
* Projects/CMakeLists.txt [USE_SYSTEM_LIBS]: Find minizip via pkg-config. Adjust targets.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I started looking into packaging Overgrowth for GNU Guix, and in this context using system libraries is preferable (even necessary, per policy). This is a first baby step toward allowing to use more system libraries.