Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds a Normalizer that inserts fabricated "forced downtime" events into the event stream. Specific fights can be configured to add forced downtime events to times when the selected player doesn't have targets to damage / heal due to way the fight flows (for example Tindral intermissions). Further modules can consume the downtime events to give better analysis - for example not yelling at the player for failing to use a cooldown during an intermission.
This pull request includes the normalizer, and a scheme to easily specify downtime windows for fights. This pull request does NOT include modules that consume the events. The normalizer on its own does not do anything visible to the user.
Planned follow-on work to use these events:
Areas for discussion:
DowntimeSpec
and theForcedDowntimeEvent
objects?Testing
Check fights with configured downtime and make sure the events are inserted as expected
/report/9zxZVkYqb3aWdCLf/22-Heroic+Tindral+Sageswift,+Seer+of+the+Flame+-+Kill+(7:13)/Azlann/standard/events