Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trusts: Added listnames setting. #2204

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

vessellaj
Copy link
Contributor

No description provided.

@RubenatorX
Copy link
Collaborator

RubenatorX commented Jul 6, 2022

Wait so... if I'm following this code properly,
You have added a setting (with no command to modify it) that makes it so that the list command spits out all trusts that are in all the sets?

It would be better if instead of that, the list command had an optional subcommand that would list out the trusts from a named set -- e.g.: trusts list vw

And then if for some reason you really really wanted to list out basically the entire contents of the settings file (for that character), could add a special flag -- maybe -verbose or something (maybe @z16 has thoughts).

But I don't think adding a hidden(read: have to go directly edit the settings file) setting is the way to go for this.

@vessellaj
Copy link
Contributor Author

Fair enough. I've added a toggle to the main commands for the name printing and a subcommand option for trusts list as asked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants