fix dangling ref

rebuild recheck
WinVector · Dec 8, 2019 · 491b588 · 491b588
1 parent b8d6e20
commit 491b588
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 7 deletions.
diff --git a/R/ft.R b/R/ft.R
@@ -193,7 +193,7 @@ BinomialOutcomeTreatment <- function(...,
     return(res)
   }
   get_transform <- function() {
-    td <- get('transform', envir = settings$state, inherits = FALSE)
+    res <- get('transform', envir = settings$state, inherits = FALSE)
     return(res)
   }
   obj$fit = fit
@@ -377,7 +377,7 @@ NumericOutcomeTreatment <- function(...,
     return(res)
   }
   get_transform <- function() {
-    td <- get('transform', envir = settings$state, inherits = FALSE)
+    res <- get('transform', envir = settings$state, inherits = FALSE)
     return(res)
   }
   obj$fit = fit
@@ -535,7 +535,7 @@ MultinomialOutcomeTreatment <- function(...,
     return(res)
   }
   get_transform <- function() {
-    td <- get('transform', envir = settings$state, inherits = FALSE)
+    res <- get('transform', envir = settings$state, inherits = FALSE)
     return(res)
   }
   obj$fit = fit
@@ -674,7 +674,7 @@ UnsupervisedTreatment <- function(...,
     return(res)
   }
   get_transform <- function() {
-    td <- get('transform', envir = settings$state, inherits = FALSE)
+    res <- get('transform', envir = settings$state, inherits = FALSE)
     return(res)
   }
   obj$fit = fit

diff --git a/cran-comments.md b/cran-comments.md
@@ -5,7 +5,6 @@
 ### OSX
 
     R CMD check --as-cran vtreat_1.4.8.tar.gz 
-    * using R version 3.6.0 (2019-04-26)
     * using platform: x86_64-apple-darwin15.6.0 (64-bit)
     * using session charset: UTF-8
     * using option ‘--as-cran’
@@ -19,6 +18,18 @@
 ### Windows
 
     rhub::check_for_cran()
+     978#> * using R Under development (unstable) (2019-11-08 r77393)
+     979#> * using platform: x86_64-w64-mingw32 (64-bit)
+     980#> * using session charset: ISO8859-1
+     981#> * using option '--as-cran'
+     982#> * checking for file 'vtreat/DESCRIPTION' ... OK
+     983#> * checking extension type ... Package
+     984#> * this is package 'vtreat' version '1.4.8'
+     985#> * checking CRAN incoming feasibility ... Note_to_CRAN_maintainers
+     986#> Maintainer: 'John Mount '
+    1028#> * checking sizes of PDF files under 'inst/doc' ... NOTE
+    1029#> Unable to find GhostScript executable to run checks on size reduction
+    1044#> Status: 1 NOTE
     GhostScript NOTE is a property of the test environment, not of the package.
 
 ## Downstream dependencies

diff --git a/extras/check_reverse_dependencies.md b/extras/check_reverse_dependencies.md
@@ -14,7 +14,7 @@ packageVersion(package)
 date()
 ```
 
-    ## [1] "Sat Dec  7 18:54:59 2019"
+    ## [1] "Sun Dec  8 10:30:26 2019"
 
 ``` r
 parallelCluster <- NULL
@@ -33,7 +33,7 @@ setwd(td)
 print(td)
 ```
 
-    ## [1] "/var/folders/7q/h_jp2vj131g5799gfnpzhdp80000gn/T//Rtmpyjdpzy"
+    ## [1] "/var/folders/7q/h_jp2vj131g5799gfnpzhdp80000gn/T//RtmpFPPBpU"
 
 ``` r
 options(repos = c(CRAN="https://cloud.r-project.org"))