Value ShowDegrade Collection (separate keys)

[martincayouette]

The collection that kept track of event handlers did not take in account the value showDegrade. We are now storing event handlers on separate keys according to the value of this parameter.

[WickyNilliams]

Hey martin, excuse the delay in response.

I'll have to think about this one. Is the current behaviour actually much of an issue? If you want one handler to degrade in old browsers, you probably want all handlers for that media query to degrade - as that would be the media query where you switch to a desktop style?

Preferably I'd also like unit tests to accompany any new functionality. It worries me that this didn't break any tests to be honest (speaks more about my unit tests than your changes).

[masyl]

Hi Nick,

I worked with Martin on this pull request. The reason that your tests are not failing is that we we're careful to make the changes backward compatible.

We had to make this fix because we we're having an unpredictable result when using then API.

We are currently doing the mobile adaptation of a large site. The various behaviors/components we have are decoupled from each-others and each of them is responsible declaring their own "enquire" events. Some are declaring events that are fallbacks, others are declaring events that are not fallbacks, with the same media-queries.

Without this fix, your library would only respect the "showDegrade" argument for the first event registered. The second registration would simply be ignored.

Your tests would have to handle such a scenario (we already have a second large project with the same dylema in the works)

[WickyNilliams]

OK thanks for providing some context, I definitely agree with the idea - what you described is how I always envisioned enquire being used. I'll have a look over everything tomorrow when I have some time free and get back to you.

Thanks again