omp_locks: Avoid extern global variable

Make `omp_locks` a variable in an unnamed namespace instead of an extern global variable. This might potentially fix the Windows symbol issue (AMReX-Codes#3795).
WeiqunZhang · Mar 11, 2024 · 56aa49a · 56aa49a
1 parent d4dcb01
commit 56aa49a
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 5 deletions.
diff --git a/Src/Base/AMReX_BaseFab.H b/Src/Base/AMReX_BaseFab.H
@@ -3362,7 +3362,7 @@ BaseFab<T>::lockAdd (const BaseFab<T>& src, const Box& srcbox, const Box& destbo
             auto const m = mm + plo;
             int ilock = m % OpenMP::nlocks;
             if (ilock < 0) { ilock += OpenMP::nlocks; }
-            auto* lock = &(OpenMP::omp_locks[ilock]);
+            auto* lock = OpenMP::get_lock(ilock);
             if (omp_test_lock(lock))
             {
                 auto lo = dlo;

diff --git a/Src/Base/AMReX_OpenMP.H b/Src/Base/AMReX_OpenMP.H
@@ -17,8 +17,7 @@ namespace amrex::OpenMP {
     void Initialize ();
     void Finalize ();
 
-    static constexpr int nlocks = 128;
-    extern AMREX_EXPORT omp_lock_t omp_locks[nlocks];
+    omp_lock_t* get_lock (int ilock);
 }
 
 #else // AMREX_USE_OMP

diff --git a/Src/Base/AMReX_OpenMP.cpp b/Src/Base/AMReX_OpenMP.cpp
@@ -135,9 +135,8 @@ namespace amrex
 #ifdef AMREX_USE_OMP
 namespace amrex::OpenMP
 {
-    omp_lock_t omp_locks[nlocks];
-
     namespace {
+        omp_lock_t omp_locks[128];
         unsigned int initialized = 0;
     }
 
@@ -204,5 +203,7 @@ namespace amrex::OpenMP
         }
     }
 
+    omp_lock_t* get_lock (int ilock) { return omp_locks + ilock; }
+
 } // namespace amrex::OpenMP
 #endif // AMREX_USE_OMP