Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve visual representation of "proposed addition/correction" parts #2584

Merged
merged 3 commits into from May 14, 2024
Merged

Improve visual representation of "proposed addition/correction" parts #2584

merged 3 commits into from May 14, 2024

Conversation

hoch
Copy link
Member

@hoch hoch commented Apr 29, 2024 •
edited by pr-preview bot

This PR include no spec content change.

  • There were some complaints about the visual aesthetic of "proposed addition/correction" and this PR adjusts a few aspects of its style to make it easier to read.
  • This PR also modernizes the old JS style for the MathJax loading script. It turned out that the "preload" section was not necessary after all and this PR will speed up the page load a bit.

Preview | Diff

@hoch hoch requested a review from padenot April 29, 2024 23:41
padenot
padenot approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@padenot padenot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but check with W3C staff.

@hoch hoch requested a review from svgeesus May 14, 2024 14:08
@hoch
Copy link
Member Author

hoch commented May 14, 2024

@svgeesus Chris, could you take a look? I believe this will improve the readability of the proposed addition/correction.

svgeesus
svgeesus approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@svgeesus svgeesus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@svgeesus svgeesus merged commit 22d71ec into main May 14, 2024
1 check passed
@svgeesus svgeesus deleted the script-clean-up branch May 14, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@padenot padenot padenot approved these changes

@svgeesus svgeesus svgeesus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hoch @padenot @svgeesus