Remove options from processor of Bitcrusher example #2492
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoch
approved these changes
Jun 2, 2022
|
Hi @hoch, thanks for the approval. However it looks like I can't merge the PR myself. GitHub only allows me to close it. |
|
Yes, we need to rework you PR to add the necessary markup for change tracking vs. the Recommendation, so it looks like this in the end: https://webaudio.github.io/web-audio-api/#c2359. |
jackromo888
approved these changes
Nov 13, 2022
|
Hi, I just wanted to say this has caused some confusion on our side as well so it would be good to have this merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is intended to fix #2491.
Preview | Diff