hide dynFrame if combat starts with living threads #5083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emptyrivers
added
🏨 Bugfix
emptyrivers
commented
May 15, 2024
| @@ -1668,8 +1668,8 @@ local function scanForLoadsImpl(toCheck, event, arg1, ...) | |||
| local encounter_id = WeakAuras.CurrentEncounter and WeakAuras.CurrentEncounter.id or 0 | |||
|
|
|||
| if (event == "ENCOUNTER_START") then | |||
| encounter_id = tonumber (arg1) | |||
| CreateEncounterTable (encounter_id) | |||
| encounter_id = tonumber(arg1) | |||
There was a problem hiding this comment.
well I didn't mean to include this change, but oh well. I'm not taking it out.
emptyrivers
changed the title
emptyrivers
force-pushed
the
pls_dont_time_me_out
branch
2 times, most recently
from
b5ab754
to
8080b4c
Compare
nothing that we put into dynFrame threads is meant for in-combat execution anyways, so to avoid random unexpectedly short timeouts, pause execution if combat starts, and resume after combat ends. There's potential for WeakAuras to be 'broken' during that combat session (due to dynamic groups being Pause()'d), but we probably couldn't have unbroken it given that ResumeAllDynamicGroups is too costly to call during combat lockdown without risking a timeout. Fixes WeakAuras#4967 (or at least, reduces its likelihood)
emptyrivers
force-pushed
the
pls_dont_time_me_out
branch
from
8080b4c
to
e65b267
Compare
|
Hmm, I think I agree with your analysis of where the bug comes from. I wonder whether dynFrame:AddAction should also do a InCombatLookdown check before showing the dynFrame. And I'm not sure what will happen if a user logins while in an encounter, whether that fires PLAYER_REGEN_DISABLED or not, and if that comes after PLAYER_LOGIN or not. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nothing that we put into dynFrame threads is meant for in-combat execution anyways, so to avoid random unexpectedly short timeouts, pause execution if combat starts, and resume after combat ends.
There's potential for WeakAuras to be 'broken' during that combat session (due to dynamic groups being Pause()'d), but we probably couldn't have unbroken it given that ResumeAllDynamicGroups is too costly to call during combat lockdown without risking a timeout.
Fixes #4967 (or at least, reduces its likelihood)