Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api Search in text editor #4983

Open
wants to merge 42 commits into
base: main
Choose a base branch
from
Open

Api Search in text editor #4983

wants to merge 42 commits into from

Conversation

mrbuds
Copy link
Contributor

@mrbuds mrbuds commented Apr 2, 2024

Description

Use Blizzard_APIDocumentation to make a side panel to help find documented wow functions (not all of them are in there sadly) or complete as you type.

Type of change

  • New feature (non-breaking change which adds functionality)

There is no known bug i want to fix, but i'm not in a hurry to merge, maybe there's some cool stuff to add i'v not think about yet

@mrbuds mrbuds added the 🆕 Feature Preview This is a draft intended to show a preview of an upcoming feature. label Apr 2, 2024
@emptyrivers
Copy link
Contributor

click snippets & search API at the same time, you get a very wide window, may or may not be desirable to ensure exactly one side panel is open at a time
image

@emptyrivers
Copy link
Contributor

consider doing some debouncing to only perform search after the user has stopped typing? and/or spread across frames

@emptyrivers
Copy link
Contributor

some events are documented. Maybe add them? IDK how to make that make sense in the UI but you're smart :)
image

@mrbuds
Copy link
Contributor Author

mrbuds commented Apr 4, 2024

some events are documented. Maybe add them?

WowClassic_2024-04-04_05-39-51.mp4

@Stanzilla
Copy link
Contributor

to pile on, can we add teh WA APIs that we offer to use from auras?

@mrbuds
Copy link
Contributor Author

mrbuds commented Apr 4, 2024

to pile on, can we add teh WA APIs that we offer to use from auras?

That would ideally be a script to generate documentation data like what's in Blizzard_APIDocumentationGenerated to feed APIDocumentation:AddDocumentationTable

Mhmm maybe .. that would help if you know someone at blizzard willing to share their own script (if they have one)

@Stanzilla
Copy link
Contributor

to pile on, can we add teh WA APIs that we offer to use from auras?

That would ideally be a script to generate documentation data like what's in Blizzard_APIDocumentationGenerated to feed APIDocumentation:AddDocumentationTable

Mhmm maybe .. that would help if you know someone at blizzard willing to share their own script (if they have one)

So kinda like https://github.com/DeadlyBossMods/LuaLS-Config/tree/main but not as intense

@mrbuds
Copy link
Contributor Author

mrbuds commented Apr 4, 2024

@Stanzilla
Copy link
Contributor

So kinda like DeadlyBossMods/LuaLS-Config@main but not as intense

I don't see how that help generate files like Gethe/wow-ui-source@ddfbf32/Interface/AddOns/Blizzard_APIDocumentationGenerated/AdventureJournalDocumentation.lua

ah nvm, my brain was confused by the discussion on discord vs this

@InfusOnWoW InfusOnWoW added 🆕 Feature Preview This is a draft intended to show a preview of an upcoming feature. and removed 🆕 Feature Preview This is a draft intended to show a preview of an upcoming feature. labels May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🆕 Feature Preview This is a draft intended to show a preview of an upcoming feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants