Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak fire effect pointlight #3698

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

past-due
Copy link
Member

Tweak fire effect pointlight:

  • Raise it above the input position (i.e. above ground) and increase the range so it better casts light.

Issues:

This change makes it easy to reproduce an apparent issue with point lights (possibly related to the near plane and the various calculations?) @vlj

Video example:
https://github.com/Warzone2100/warzone2100/assets/30942300/d44ddc4b-f94a-4c31-a813-f96b3c4f3bd8

Here's a save game that should let you reproduce this.
Sk-Rush-fire-lights.zip

Steps to reproduce are:

  1. Ensure point lights are on in Graphics settings
  2. Load the Sk-Rush-fire-lights skirmish save game
  3. Zoom in on the cluster of walls surrounding the oil derrick (where all the cyborgs are attacking), and potentially rotate to match the video example
  4. The closer you zoom, the more readily you'll be able to see the "dividing line" where pointlights aren't having the expected impact (seems to be for things that are closer to the camera - if enabling debug mode, which lets you zoom in even more, you can see how big an impact this can be)

@MaNGusT-
Copy link
Contributor

mb it's those bug/glitch of camera's near far/end values?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants